The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is
Effort is min
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
170 | 178 | 0 | 0 |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.JbiServiceDescriptor defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 185 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of children in it.imolinfo.jbi4corba.jbi.component.Jbi4CorbaRuntime.resolveEndpointReference(DocumentFragment) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 107 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to writer in it.imolinfo.jbi4corba.jbi.component.Jbi4CorbaSUManager.populateEndpointWSDLInfo(EndpointStatus, Jbi4CorbaEndpoint) | STYLE | DLS_DEAD_LOCAL_STORE | 1033 | Medium |
Dead store to documentBuilder in it.imolinfo.jbi4corba.jbi.component.Jbi4CorbaSUManager.processDeploy(String, String, StatusProviderHelper) | STYLE | DLS_DEAD_LOCAL_STORE | 480 | Medium |
Possible null pointer dereference of svcs in it.imolinfo.jbi4corba.jbi.component.Jbi4CorbaSUManager.getJbiDescriptors(String, String, List) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 1114 | Medium |
Method call in it.imolinfo.jbi4corba.jbi.component.Jbi4CorbaSUManager.getJbiDescriptors(String, String, List) passes null for nonnull parameter of it.imolinfo.jbi4corba.jbi.wsdl.Jbi4CorbaExtensionUtils.getCorbaAddress(Definition, String, String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 1182 | Medium |
it.imolinfo.jbi4corba.jbi.component.Jbi4CorbaSUManager.createServiceDescriptor(Service, Binding, PortType, Jbi4CorbaAddress, Jbi4CorbaBinding, String, String) ignores exceptional return value of java.io.File.createNewFile() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 929 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.component.runtime.AbstractComponentLifeCycle.JBI4CORBABC_PERF_CATEGORIES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 71 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.component.runtime.AbstractMessageExchangeHandler.IN_MESSAGE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 27 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of installContext in it.imolinfo.jbi4corba.jbi.component.runtime.ComponentInstaller.init(InstallationContext) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 81 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread field: it.imolinfo.jbi4corba.jbi.component.runtime.DefaultServiceUnitManager.mContext | PERFORMANCE | URF_UNREAD_FIELD | 38 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Synchronization on Boolean could deadlock in it.imolinfo.jbi4corba.jbi.component.runtime.MessageExchangeReceiver.shutdownReceiver() | MT_CORRECTNESS | DL_SYNCHRONIZATION_ON_BOOLEAN | 204 | High |
Synchronization on Boolean could deadlock in it.imolinfo.jbi4corba.jbi.component.runtime.MessageExchangeReceiver.startProcessing() | MT_CORRECTNESS | DL_SYNCHRONIZATION_ON_BOOLEAN | 274 | High |
Synchronization on Boolean could deadlock in it.imolinfo.jbi4corba.jbi.component.runtime.MessageExchangeReceiver.stopProcessing() | MT_CORRECTNESS | DL_SYNCHRONIZATION_ON_BOOLEAN | 284 | High |
Synchronization on MessageExchangeReceiver.mContinue in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 206 | High |
Synchronization on MessageExchangeReceiver.mCanAccept in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 276 | High |
Synchronization on MessageExchangeReceiver.mCanAccept in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 286 | High |
Write to static field it.imolinfo.jbi4corba.jbi.component.runtime.MessageExchangeReceiver.HANDLER_THREAD_POOL_SIZE from instance method it.imolinfo.jbi4corba.jbi.component.runtime.MessageExchangeReceiver.initReceiver(RuntimeConfiguration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 150 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeConfiguration.APPVAR_ROW_TYPE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeConfiguration.APPVAR_TABULAR_TYPE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
Load of known null value in it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeConfiguration.loadApplicationConfiguration(String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 542 | Medium |
Write to static field it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeConfiguration.APPVAR_ROW_TYPE from instance method new it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeConfiguration(String, String, String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 146 | Medium |
Write to static field it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeConfiguration.APPVAR_TABULAR_TYPE from instance method new it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeConfiguration(String, String, String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 147 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible doublecheck on it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeContext.sRuntimeContext in it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeContext.getInstance() | MT_CORRECTNESS | DC_DOUBLECHECK | 42-44 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.component.runtime.RuntimeHelper.readFromInputSource(InputSource) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 576 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.component.runtime.ServiceDescriptor.getOperations() may expose internal representation by returning ServiceDescriptor.mOperations | MALICIOUS_CODE | EI_EXPOSE_REP | 177 | Medium |
it.imolinfo.jbi4corba.jbi.component.runtime.ServiceDescriptor.getServiceTypes() may expose internal representation by returning ServiceDescriptor.mServiceTypes | MALICIOUS_CODE | EI_EXPOSE_REP | 123 | Medium |
it.imolinfo.jbi4corba.jbi.component.runtime.ServiceDescriptor.setOperations(ServiceDescriptor$OperationDescriptor[]) may expose internal representation by storing an externally mutable object into ServiceDescriptor.mOperations | MALICIOUS_CODE | EI_EXPOSE_REP2 | 196 | Medium |
it.imolinfo.jbi4corba.jbi.component.runtime.ServiceDescriptor.setServiceTypes(QName[]) may expose internal representation by storing an externally mutable object into ServiceDescriptor.mServiceTypes | MALICIOUS_CODE | EI_EXPOSE_REP2 | 142 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaConsumerExceptionInterceptor.unmarshallArray(Unmarshaller, Object, QName, Class, List), since all javax.xml.bind.JAXBElement are instances of javax.xml.bind.JAXBElement | STYLE | BC_VACUOUS_INSTANCEOF | 456 | Medium |
Dead store to accessorType in it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaConsumerExceptionInterceptor.unmarshallException(Unmarshaller, Object, MessagePartInfo) | STYLE | DLS_DEAD_LOCAL_STORE | 340 | Medium |
Possible null pointer dereference of reader in it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaConsumerExceptionInterceptor.unmarshallArray(Unmarshaller, Object, QName, Class, List) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 454 | High |
Possible null pointer dereference of e in it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaConsumerExceptionInterceptor.processFaultDetail(Fault, Message) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 167 | Medium |
Possible null pointer dereference of reader in it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaConsumerExceptionInterceptor.unmarshallException(Unmarshaller, Object, MessagePartInfo) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 321 | Medium |
Nullcheck of e at line 174 of value previously dereferenced in it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaConsumerExceptionInterceptor.processFaultDetail(Fault, Message) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 167 | High |
Nullcheck of e at line 191 of value previously dereferenced in it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaConsumerExceptionInterceptor.processFaultDetail(Fault, Message) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 167 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to newTopEntry in it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaIdlPreprocessor.popInclude() | STYLE | DLS_DEAD_LOCAL_STORE | 203 | Medium |
Dead store to reader in it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaIdlPreprocessor.popInclude() | STYLE | DLS_DEAD_LOCAL_STORE | 205 | Medium |
it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaIdlPreprocessor.idlSet is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | Not available | High |
it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaIdlPreprocessor.fillBuffer() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 135 | High |
it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaIdlPreprocessor.fillBuffer() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 134 | High |
it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaIdlPreprocessor.fillBuffer() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 134 | High |
it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaIdlPreprocessor.getIdlURL() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 246 | High |
Unused field: it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaIdlPreprocessor.readPos | PERFORMANCE | UUF_UNUSED_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaServiceConfiguration.getWrapperPartMaxOccurs(MessagePartInfo) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 34 | Medium |
Method it.imolinfo.jbi4corba.jbi.cxf.Jbi4CorbaServiceConfiguration.getWrapperPartMinOccurs(MessagePartInfo) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 27 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Null pointer dereference of part in it.imolinfo.jbi4corba.jbi.cxf.OutMarshallerHelper.marshal(Marshaller, Object, MessagePartInfo, Object) | CORRECTNESS | NP_ALWAYS_NULL | 177 | High |
Load of known null value in it.imolinfo.jbi4corba.jbi.cxf.OutMarshallerHelper.marshal(Marshaller, Object, MessagePartInfo, Object) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 177 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.endpoint.ConsumerEndpoint.writeWSDLDocument(Definition) ignores exceptional return value of java.io.File.mkdir() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 688 | Medium |
Class it.imolinfo.jbi4corba.jbi.endpoint.ConsumerEndpoint defines non-transient non-serializable instance field consumerExchangeProcessor | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class it.imolinfo.jbi4corba.jbi.endpoint.ConsumerEndpoint defines non-transient non-serializable instance field consumerServiceDescriptor | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.endpoint.ProviderEndpoint.readIorFromFile(String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 929 | Medium |
Nullcheck of ProviderEndpoint.serviceDescriptor at line 413 of value previously dereferenced in it.imolinfo.jbi4corba.jbi.endpoint.ProviderEndpoint.initOrb() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 410 | Medium |
Class it.imolinfo.jbi4corba.jbi.endpoint.ProviderEndpoint defines non-transient non-serializable instance field narrowMethod | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class it.imolinfo.jbi4corba.jbi.endpoint.ProviderEndpoint defines non-transient non-serializable instance field orb | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Method it.imolinfo.jbi4corba.jbi.endpoint.ProviderEndpoint.initOrb() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 439 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.processor.ProviderExchangeProcessor.process(MessageExchange) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 172 | Medium |
Method call in it.imolinfo.jbi4corba.jbi.processor.ProviderExchangeProcessor.invokeCXFOperation(Exchange, Service, QName, Source, boolean) passes null for nonnull parameter of it.imolinfo.jbi4corba.jbi.cxf.CXFUtils.getBindingStyle(BindingOperationInfo) | CORRECTNESS | NP_NULL_PARAM_DEREF | 628 | High |
Exception is caught when Exception is not thrown in it.imolinfo.jbi4corba.jbi.processor.ProviderExchangeProcessor.process(MessageExchange) | STYLE | REC_CATCH_EXCEPTION | 446 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.jbi.wsdl.Jbi4CorbaAddressDeserializer.unmarshall(Class, QName, Element, Definition, ExtensionRegistry) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 100 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Call to equals() comparing different types in it.imolinfo.jbi4corba.jbi.wsdl.Jbi4CorbaExtPreprocessDeserializer.unmarshall(Class, QName, Element, Definition, ExtensionRegistry) | CORRECTNESS | EC_UNRELATED_TYPES | 52 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of IOR in it.imolinfo.jbi4corba.utils.HelperEPRUtils.getDynamicIORFromEPR(Node) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 117 | Medium |
Possible null pointer dereference of document in it.imolinfo.jbi4corba.utils.HelperEPRUtils.readAddressFromEPR(String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 81 | Medium |
Bug | Category | Details | Line | Priority |
---|
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.utils.HelperIDLJUtil.idlj(String, String, String) ignores exceptional return value of java.io.File.mkdir() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 52 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The method name it.imolinfo.jbi4corba.utils.HelperStringUtils.ExtractString(String, String, String) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 27-36 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of args in it.imolinfo.jbi4corba.utils.IDL2WSDLTool.main(String[]) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 75 | Medium |
Nullcheck of def at line 221 of value previously dereferenced in it.imolinfo.jbi4corba.utils.IDL2WSDLTool.main(String[]) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 221 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.webservice.descriptor.ConsumerServiceDescriptor defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 166 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.webservice.descriptor.ProviderServiceDescriptor defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 250 | High |
Class it.imolinfo.jbi4corba.webservice.descriptor.ProviderServiceDescriptor defines non-transient non-serializable instance field originalClassLoader | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class it.imolinfo.jbi4corba.webservice.descriptor.ProviderServiceDescriptor defines non-transient non-serializable instance field urlClassLoader | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Bug | Category | Details | Line | Priority |
---|
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.webservice.generator.ClientCorbaClassesHolder defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 138 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to serviceName in it.imolinfo.jbi4corba.webservice.generator.ConsumerServiceClassesGenerator.generateConsumerServiceClassesDirectFromWSDL(File, List) | STYLE | DLS_DEAD_LOCAL_STORE | 656 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.ConsumerServiceClassesGenerator.tweakUID(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 1221 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method it.imolinfo.jbi4corba.webservice.generator.HolderUtils.findMethod(Method, MethodSignature, boolean, Set, Set) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 214 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Nullcheck of retType at line 110 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.InterfaceTypeUtils.changeInterfaceTypeDesc(String, Map) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 110 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.InterfaceTypeUtils.changeInterfaceTypeDesc(String, Map) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 102 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.webservice.generator.MethodSignature defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 102 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.webservice.generator.Param defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 89 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.webservice.generator.ProviderServiceClassesGenerator.codeGenerationProperties should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 73 | Medium |
Nullcheck of jaxbJarLocation at line 250 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.ProviderServiceClassesGenerator.generateProviderServiceClasses(List, String, String, List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 250 | Medium |
it.imolinfo.jbi4corba.webservice.generator.ProviderServiceClassesGenerator.createsPackageInfo(String, String, String) ignores exceptional return value of java.io.File.createNewFile() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1032 | Medium |
Write to static field it.imolinfo.jbi4corba.webservice.generator.ProviderServiceClassesGenerator.codeGenerationProperties from instance method new it.imolinfo.jbi4corba.webservice.generator.ProviderServiceClassesGenerator(CodeGenerationProperties) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 111 | High |
Method it.imolinfo.jbi4corba.webservice.generator.ProviderServiceClassesGenerator.generateProviderServiceClasses(List, String, List, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 519 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.ProviderServiceClassesGenerator.updateOnewayMethodSignature(Map, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 1076 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.webservice.generator.ServerCorbaClassesHolder defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 167 | High |
Unread field: it.imolinfo.jbi4corba.webservice.generator.ServerCorbaClassesHolder.substitutedInterfaceFields | PERFORMANCE | URF_UNREAD_FIELD | 66 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Nullcheck of typeName at line 141 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.TypeUtils.findType(Class, String, Map, TCKind) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 127 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Call to equals() comparing different types in it.imolinfo.jbi4corba.webservice.generator.Util.findDirectories(File) | CORRECTNESS | EC_UNRELATED_TYPES | 520 | High |
Possible null pointer dereference of pathList in it.imolinfo.jbi4corba.webservice.generator.Util.extractSerialVersionUid(String, List) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 2718 | Medium |
Possible null pointer dereference of labelList in it.imolinfo.jbi4corba.webservice.generator.Util.generateSpecialEnumClass(String, String, List) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 2293 | Medium |
Nullcheck of helperclazz at line 826 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.Util.getTypesMap(String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 826 | Medium |
it.imolinfo.jbi4corba.webservice.generator.Util.createUniqueDirectory(File, String) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 2851 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.Util.compileRemoteClassesNoValueMethodsOFF(String, String, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 149 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.Util.compileRemoteClassesNoValueMethodsON(String, String, List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 114 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.Util.generateTheBodyOfTheMethodForImplTie(MethodSignature, boolean) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 2630 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.Util.debug(String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 2825 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.Util.replaceCorbaEnumaration(String, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 2214 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method it.imolinfo.jbi4corba.webservice.generator.UtilJavaSourceParsing.getParamFromNode(DetailAST) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 497 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.webservice.generator.WSDLGenerator.changeNotNeededIncludeStatus(Set, int) is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 217-228 | High |
Possible null pointer dereference of desc in it.imolinfo.jbi4corba.webservice.generator.WSDLGenerator.generateWSDLListfromIDL(File, ArrayList) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 357 | Medium |
Nullcheck of wrapper at line 745 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.WSDLGenerator.createRemoveXSD(List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 745 | Medium |
it.imolinfo.jbi4corba.webservice.generator.WSDLGenerator.deleteDirectory(File) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 948 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.WSDLGenerator.addRequiredSchemaImports(Schema, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 1019 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on exceptions in it.imolinfo.jbi4corba.webservice.generator.bcm.AddExceptionSuperclass.visitMethod(int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 91 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method it.imolinfo.jbi4corba.webservice.generator.bcm.AnnotationWriterAdapter.visit(int, int, String, String, String, String[]) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 89 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.bcm.AnnotationWriterAdapter.visitField(int, String, String, String, Object) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 182 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.bcm.AnnotationWriterAdapter.visitMethod(int, String, String, String, String[]) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 137 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on exceptions in it.imolinfo.jbi4corba.webservice.generator.bcm.ConstructorAdapter.visitMethod(int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 120 | Medium |
Method it.imolinfo.jbi4corba.webservice.generator.bcm.ConstructorAdapter.changeInterfaceTypeDesc(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 185 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on interfaces in it.imolinfo.jbi4corba.webservice.generator.bcm.CorbaEnumAdapter.visit(int, int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 69 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on interfaces in it.imolinfo.jbi4corba.webservice.generator.bcm.CorbaOnewayAdapter.visit(int, int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 73 | Medium |
Invocation of toString on exceptions in it.imolinfo.jbi4corba.webservice.generator.bcm.CorbaOnewayAdapter.visitMethod(int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 128 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on exceptions in it.imolinfo.jbi4corba.webservice.generator.bcm.IdlToWsdlAdapter.visitMethod(int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 219 | Medium |
Nullcheck of av at line 191 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.bcm.IdlToWsdlAdapter.addAnnotation() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 191 | Medium |
Nullcheck of xmlElem at line 363 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.bcm.IdlToWsdlAdapter.visitField(int, String, String, String, Object) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 363 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method it.imolinfo.jbi4corba.webservice.generator.bcm.InternalMethodDescriptionParser.getNextParam(String) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 90 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method new it.imolinfo.jbi4corba.webservice.generator.bcm.SerializableDecorationAdapter(ClassVisitor, Long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 44 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on interfaces in it.imolinfo.jbi4corba.webservice.generator.bcm.ValueTypeAdapter.visit(int, int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 77 | Medium |
Invocation of toString on exceptions in it.imolinfo.jbi4corba.webservice.generator.bcm.ValueTypeAdapter.visitMethod(int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 153 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on exceptions in it.imolinfo.jbi4corba.webservice.generator.bcm.WebServiceAnnotationAdapter.visitMethod(int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 340 | Medium |
it.imolinfo.jbi4corba.webservice.generator.bcm.WebServiceAnnotationAdapter.noAnnotatedMethods isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 148 | High |
Nullcheck of av at line 244 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.bcm.WebServiceAnnotationAdapter.addAnnotation(String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 244 | Medium |
Nullcheck of av2 at line 256 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.bcm.WebServiceAnnotationAdapter.addAnnotation(String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 256 | Medium |
Nullcheck of av3 at line 267 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.generator.bcm.WebServiceAnnotationAdapter.addAnnotation(String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 267 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should it.imolinfo.jbi4corba.webservice.generator.bcm.WebServiceAnnotationAdapter$SignatureDescription be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 678-688 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on interfaces in it.imolinfo.jbi4corba.webservice.generator.bcm.WsdlToCorbaAdapter.visit(int, int, String, String, String, String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 92 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to helperDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.ComplexArrayTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 67 | Medium |
Dead store to javaLangClassDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.ComplexArrayTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 70 | Medium |
Dead store to xmlTransientDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.ComplexArrayTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 75 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to helperDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.ComplexTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 101 | Medium |
Dead store to javaLangClassDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.ComplexTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 104 | Medium |
Dead store to xmlTransientDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.ComplexTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 107 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to helperDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.SimpleTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 89 | Medium |
Dead store to javaLangClassDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.SimpleTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 92 | Medium |
Dead store to objectArrayClassDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.SimpleTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 85 | Medium |
Dead store to xmlTransientDescriptor in it.imolinfo.jbi4corba.webservice.generator.typedef.SimpleTypeDef.createTypeDefClass(String) | STYLE | DLS_DEAD_LOCAL_STORE | 96 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true in it.imolinfo.jbi4corba.webservice.runtime.ConsumerInvocationHandler.fromXMLToObject(String, Method), since all java.util.List are instances of java.util.List | STYLE | BC_VACUOUS_INSTANCEOF | 1259 | Medium |
it.imolinfo.jbi4corba.webservice.runtime.ConsumerInvocationHandler.exchangeStatusACTIVE(InOut, Method) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 1063 | Medium |
it.imolinfo.jbi4corba.webservice.runtime.ConsumerInvocationHandler.invoke(Object, Method, Object[]) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 344 | Medium |
A known null value is checked to see if it is an instance of java.util.List in it.imolinfo.jbi4corba.webservice.runtime.ConsumerInvocationHandler.fromXMLToObject(String, Method) | CORRECTNESS | NP_NULL_INSTANCEOF | 1289 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method it.imolinfo.jbi4corba.webservice.runtime.ConsumerServiceCreator.createJbiService(ConsumerServiceDescriptor) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 270 | Medium |
Method it.imolinfo.jbi4corba.webservice.runtime.ConsumerServiceCreator.createJbiServicePRE(ConsumerServiceDescriptor) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 787 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Invocation of toString on arrayOfObject in it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformFromAny(Any, TypeCode, InputStream, RuntimeInformation) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1442 | Medium |
Invocation of toString on localObject in it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformFromAny(Any, TypeCode, InputStream, RuntimeInformation) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1382 | Medium |
Invocation of toString on dimentions in it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformToCorbaType(Object, SearchedType, Object, RuntimeInformation, boolean) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 1958 | Medium |
it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformFromAny(Any, TypeCode, InputStream, RuntimeInformation) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 1164 | Medium |
Method it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformFromAny(Any, TypeCode, InputStream, RuntimeInformation) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | 1216 | Medium |
Method it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformFromAny(Any, TypeCode, InputStream, RuntimeInformation) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 1180 | Medium |
Method it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformFromAny(Any, TypeCode, InputStream, RuntimeInformation) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1148 | Medium |
Method it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformFromAny(Any, TypeCode, InputStream, RuntimeInformation) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 1205 | Medium |
Method it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformFromAny(Any, TypeCode, InputStream, RuntimeInformation) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | 1224 | Medium |
it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.transformFromAny(Any, TypeCode, InputStream, RuntimeInformation) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 1264 | Medium |
Possible null pointer dereference of ior in it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.changeFromServiceToCorbaObject(Object, RuntimeInformation, Class) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 401 | Medium |
Possible null pointer dereference of ior in it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.changeHoldersFromServiceToCorbaObjects(MethodSignature, List, RuntimeInformation) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 532 | Medium |
Possible null pointer dereference of serviceDesc in it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.objectToEPR(Object, Jbi4CorbaEndpoint, Class) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 2267 | Medium |
Redundant nullcheck of serviceObject, which is known to be non-null in it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.changeFromServiceToCorbaObject(Object, RuntimeInformation, Class) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 327 | Medium |
Nullcheck of value at line 551 of value previously dereferenced in it.imolinfo.jbi4corba.webservice.runtime.CorbaTransformationUtils.changeHoldersFromServiceToCorbaObjects(MethodSignature, List, RuntimeInformation) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 548 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
it.imolinfo.jbi4corba.webservice.runtime.ProviderServiceInvoker.invoke(Exchange, Object) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 337 | Medium |